harmony: fix sizing on webusb chooser dialog

ui/views/bubble/bubble_dialog_delegate.cc

Index: ui/views/bubble/bubble_dialog_delegate.cc
diff --git a/ui/views/bubble/bubble_dialog_delegate.cc b/ui/views/bubble/bubble_dialog_delegate.cc
index 735a2237bcb536fb0bb272a2fa06b6abff199ae6..0a85b59ead1d6eb77b63a32e53bbbd8edf11c361 100644
--- a/ui/views/bubble/bubble_dialog_delegate.cc
+++ b/ui/views/bubble/bubble_dialog_delegate.cc
@@ -231,9 +231,10 @@ gfx::Rect BubbleDialogDelegateView::GetBubbleBounds() {
   // The argument rect has its origin at the bubble's arrow anchor point;
   // its size is the preferred size of the bubble's client view (this view).
   bool anchor_minimized = anchor_widget() && anchor_widget()->IsMinimized();
+  gfx::Size size = GetWidget()->client_view()->GetPreferredSize();
+  size.SetToMax(GetPreferredSize());

[sky, 2017/02/24 21:15:19]

I would expect GetPreferredSize() to include the preferred size of the client
view. In other words, I'm suggesting these two lines should be:

const gfx::Size size = GetPreferredSize();

(or just use GetPreferredSize() below).

Is GetPreferredSize() not including the preferred size of the client-view? If
not, could you investigate why it isn't.

[tapted, 2017/02/27 22:17:36]

DialogClientView actually has some bugs around feeding up min/max/preferred
sizes when incorporating the requests of both the buttons row and the
ContentsView. I'm fixing them in https://codereview.chromium.org/2706423002/
(with a test \o/).

It's possible that CL fixes things here too...

   return GetBubbleFrameView()->GetUpdatedWindowBounds(
-      GetAnchorRect(), GetWidget()->client_view()->GetPreferredSize(),
-      adjust_if_offscreen_ && !anchor_minimized);
+      GetAnchorRect(), size, adjust_if_offscreen_ && !anchor_minimized);
 }
 
 const gfx::FontList& BubbleDialogDelegateView::GetTitleFontList() const {