harmony: fix sizing on webusb chooser dialog

ui/views/bubble/bubble_dialog_delegate.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_dialog_delegate.h"
 
 #include "build/build_config.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/base/default_style.h"
 #include "ui/base/material_design/material_design_controller.h"
@@ skipping 213 matching lines @@
                                      kPanelHorizMargin);
   if (anchor_view)
     SetAnchorView(anchor_view);
   UpdateColorsFromTheme(GetNativeTheme());
 }
 
 gfx::Rect BubbleDialogDelegateView::GetBubbleBounds() {
   // The argument rect has its origin at the bubble's arrow anchor point;
   // its size is the preferred size of the bubble's client view (this view).
   bool anchor_minimized = anchor_widget() && anchor_widget()->IsMinimized();
+  gfx::Size size = GetWidget()->client_view()->GetPreferredSize();
+  size.SetToMax(GetPreferredSize());

[sky, 2017/02/24 21:15:19]

I would expect GetPreferredSize() to include the preferred size of the client
view. In other words, I'm suggesting these two lines should be:

const gfx::Size size = GetPreferredSize();

(or just use GetPreferredSize() below).

Is GetPreferredSize() not including the preferred size of the client-view? If
not, could you investigate why it isn't.

[tapted, 2017/02/27 22:17:36]

DialogClientView actually has some bugs around feeding up min/max/preferred
sizes when incorporating the requests of both the buttons row and the
ContentsView. I'm fixing them in https://codereview.chromium.org/2706423002/
(with a test \o/).

It's possible that CL fixes things here too...

   return GetBubbleFrameView()->GetUpdatedWindowBounds(
-      GetAnchorRect(), GetWidget()->client_view()->GetPreferredSize(),
-      adjust_if_offscreen_ && !anchor_minimized);
+      GetAnchorRect(), size, adjust_if_offscreen_ && !anchor_minimized);
 }
 
 const gfx::FontList& BubbleDialogDelegateView::GetTitleFontList() const {
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   if (ui::MaterialDesignController::IsSecondaryUiMaterial())
     return rb.GetFontListWithDelta(ui::kTitleFontSizeDelta);
   return rb.GetFontList(ui::ResourceBundle::MediumFont);
 }
 
 void BubbleDialogDelegateView::OnNativeThemeChanged(
@@ skipping 77 matching lines @@
   // http://crbug.com/474622 for details.
   if (widget == GetWidget() && visible) {
     ui::AXNodeData node_data;
     GetAccessibleNodeData(&node_data);
     if (node_data.role == ui::AX_ROLE_ALERT_DIALOG)
       NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);
   }
 }
 
 }  // namespace views