Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2692103003: Remove duplicate Shift+Search+0 entry in the keyboard overlay (Closed)

Created:
3 years, 10 months ago by afakhry
Modified:
3 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate Shift+Search+0 entry in the keyboard overlay BUG=619424 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2692103003 Cr-Commit-Position: refs/heads/master@{#450419} Committed: https://chromium.googlesource.com/chromium/src/+/cf33bdcae3a0560499e73ba26c143f3aafb61601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
afakhry
Xiyuan, please review this minor change. Thanks!
3 years, 10 months ago (2017-02-14 02:25:48 UTC) #3
xiyuan
lgtm
3 years, 10 months ago (2017-02-14 16:07:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692103003/1
3 years, 10 months ago (2017-02-14 17:18:50 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 18:44:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cf33bdcae3a0560499e73ba26c14...

Powered by Google App Engine
This is Rietveld 408576698