Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 26921004: Work around broken GL_TEXTURE_BINDING_EXTERNAL_OES query (Closed)

Created:
7 years, 2 months ago by no sievers
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org, qinmin
Visibility:
Public.

Description

Work around broken GL_TEXTURE_BINDING_EXTERNAL_OES query glGetIntegerv(GL_TEXTURE_BINDING_EXTERNAL_OES, &texture_id) returns GL_INVALID_ENUM on older Android NVIDIA drivers. The reason for the query is to restore correct texture bindings, since SurfaceTexture.updateTexImage() implies a call to glBindTexture(). Since we now only call this before drawing, we can just set the correct active texture unit (which gets restored after draw). BUG=305526, 283053 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229254

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M content/common/gpu/stream_texture_manager_android.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 chunks +8 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
no sievers
ptal
7 years, 2 months ago (2013-10-17 22:54:53 UTC) #1
epennerAtGoogle
On 2013/10/17 22:54:53, sievers wrote: > ptal lgtm Neat also that there is no need ...
7 years, 2 months ago (2013-10-17 23:08:53 UTC) #2
no sievers
7 years, 2 months ago (2013-10-17 23:28:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r229254 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698