Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2692063004:
Release gpu::ContextGroup in gpu::InProcessCommandBuffer on GPU thread (Closed)
|
Created:
3 years, 10 months ago by tzik Modified:
3 years, 10 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, piman+watch_chromium.org, vmiura, Zhenyao Mo Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRelease gpu::ContextGroup in gpu::InProcessCommandBuffer on GPU thread
ContextGroup has a non-thread-safe ref count.
It is created on the GPU thread, and held on the GPU thread by
InProcessCommandBuffers and GLES2Decoder. Though GLES2Decoder releases
the reference on the GPU thread, InProcessCommandBuffer releases it on
the main thread, that causes a data race on the ContextGroup ref count.
BUG=690966
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2692063004
Cr-Commit-Position: refs/heads/master@{#450569}
Committed: https://chromium.googlesource.com/chromium/src/+/684418e9e512ef89bab2af1e0d0e99d055bc94a7
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
Description was changed from ========== Release gpu::ContextGroup in gpu::InProcessCommandBuffer on GPU thread ContextGroup has a non-thread-safe ref count. It is created on the GPU thread, and held on the GPU thread by InProcessCommandBuffers and GLES2Decoder. Though GLES2Decoder releases the reference on the GPU thread, InProcessCommandBuffer releases it on the main thread, that causes a data race on the ContextGroup ref count. ========== to ========== Release gpu::ContextGroup in gpu::InProcessCommandBuffer on GPU thread ContextGroup has a non-thread-safe ref count. It is created on the GPU thread, and held on the GPU thread by InProcessCommandBuffers and GLES2Decoder. Though GLES2Decoder releases the reference on the GPU thread, InProcessCommandBuffer releases it on the main thread, that causes a data race on the ContextGroup ref count. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Release gpu::ContextGroup in gpu::InProcessCommandBuffer on GPU thread ContextGroup has a non-thread-safe ref count. It is created on the GPU thread, and held on the GPU thread by InProcessCommandBuffers and GLES2Decoder. Though GLES2Decoder releases the reference on the GPU thread, InProcessCommandBuffer releases it on the main thread, that causes a data race on the ContextGroup ref count. ========== to ========== Release gpu::ContextGroup in gpu::InProcessCommandBuffer on GPU thread ContextGroup has a non-thread-safe ref count. It is created on the GPU thread, and held on the GPU thread by InProcessCommandBuffers and GLES2Decoder. Though GLES2Decoder releases the reference on the GPU thread, InProcessCommandBuffer releases it on the main thread, that causes a data race on the ContextGroup ref count. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tzik@chromium.org changed reviewers: + kbr@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please reference a bug ID from the CL description. This must have been caught by one of the fuzzers and we'd like to keep track of more details. LGTM vmiura, zmo: FYI.
Description was changed from ========== Release gpu::ContextGroup in gpu::InProcessCommandBuffer on GPU thread ContextGroup has a non-thread-safe ref count. It is created on the GPU thread, and held on the GPU thread by InProcessCommandBuffers and GLES2Decoder. Though GLES2Decoder releases the reference on the GPU thread, InProcessCommandBuffer releases it on the main thread, that causes a data race on the ContextGroup ref count. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Release gpu::ContextGroup in gpu::InProcessCommandBuffer on GPU thread ContextGroup has a non-thread-safe ref count. It is created on the GPU thread, and held on the GPU thread by InProcessCommandBuffers and GLES2Decoder. Though GLES2Decoder releases the reference on the GPU thread, InProcessCommandBuffer releases it on the main thread, that causes a data race on the ContextGroup ref count. BUG=690966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2017/02/14 23:52:07, Ken Russell wrote: > Please reference a bug ID from the CL description. This must have been caught by > one of the fuzzers and we'd like to keep track of more details. > > LGTM > > vmiura, zmo: FYI. Updated. http://crbug.com/690966 is probably related to this.
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487131132435650, "parent_rev":
"b01cf346a85f9341961bd95a219cd69eee4fa9d9", "commit_rev":
"684418e9e512ef89bab2af1e0d0e99d055bc94a7"}
Message was sent while issue was closed.
Description was changed from ========== Release gpu::ContextGroup in gpu::InProcessCommandBuffer on GPU thread ContextGroup has a non-thread-safe ref count. It is created on the GPU thread, and held on the GPU thread by InProcessCommandBuffers and GLES2Decoder. Though GLES2Decoder releases the reference on the GPU thread, InProcessCommandBuffer releases it on the main thread, that causes a data race on the ContextGroup ref count. BUG=690966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Release gpu::ContextGroup in gpu::InProcessCommandBuffer on GPU thread ContextGroup has a non-thread-safe ref count. It is created on the GPU thread, and held on the GPU thread by InProcessCommandBuffers and GLES2Decoder. Though GLES2Decoder releases the reference on the GPU thread, InProcessCommandBuffer releases it on the main thread, that causes a data race on the ContextGroup ref count. BUG=690966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2692063004 Cr-Commit-Position: refs/heads/master@{#450569} Committed: https://chromium.googlesource.com/chromium/src/+/684418e9e512ef89bab2af1e0d0e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/684418e9e512ef89bab2af1e0d0e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
