Remove last MD reference from TrayPopupUtils.

Remove last MD reference from TrayPopupUtils.

Remove NonMdSlider. Merge MdSlider and Slider.

BUG=686288, 686215
Review-Url: https://codereview.chromium.org/2692043009
Cr-Commit-Position: refs/heads/master@{#452148}
Committed: https://chromium.googlesource.com/chromium/src/+/66c91e5046e5f7430e4f62593a1fe5d6dfe347de

[Evan Stade, 2017-02-16 01:02:39]

Description was changed from

==========
wip - remove nonmd slider

BUG=
==========

to

==========
Remove last MD reference from TrayPopupUtils.

Remove NonMdSlider. Merge MdSlider and Slider.

BUG=686288
==========

[Evan Stade, 2017-02-16 01:02:40]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org

[Evan Stade, 2017-02-16 01:15:52]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 01:17:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 02:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 02:06:30]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Evan Stade, 2017-02-16 19:44:30]

estade@chromium.org changed reviewers:
+ msw@chromium.org, tdanderson@chromium.org
- sadrul@chromium.org

[Evan Stade, 2017-02-16 19:44:30]

+msw for ui/views as sadrul is ooo
+tdanderson for ash

[msw, 2017-02-16 21:08:20]

lgtm with nits and idr/image removal.

https://codereview.chromium.org/2692043009/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/tray_popup_utils.cc (right):

https://codereview.chromium.org/2692043009/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_popup_utils.cc:237:
views::CreateEmptyBorder(gfx::Insets(0, kTrayPopupSliderPaddingMD)));
nit: drop 'MD' from constant (and move to this function, its only user?)

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/non_m...
File ui/views/controls/non_md_slider.cc (left):

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/non_m...
ui/views/controls/non_md_slider.cc:17: IDR_SLIDER_ACTIVE_LEFT,
IDR_SLIDER_ACTIVE_CENTER, IDR_SLIDER_PRESSED_CENTER,
Please also remove the now unused IDR_SLIDER_* ids and associated images.

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/slide...
File ui/views/controls/slider.cc (right):

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/slide...
ui/views/controls/slider.cc:82: SchedulePaint();
q: needed? (presumably it'll schedule a paint when added to a view hier.)

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/slider.h
File ui/views/controls/slider.h (right):

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/slide...
ui/views/controls/slider.h:99: void OnPaint(gfx::Canvas* canvas) override;
nit: match order to view.h (btw GetAccessibleNodeData and OnFocus), ditto in cc

[tdanderson, 2017-02-16 22:03:50]

ash/ lgtm with two comments

https://codereview.chromium.org/2692043009/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/tray_popup_utils.cc (right):

https://codereview.chromium.org/2692043009/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_popup_utils.cc:2: // Use of this source code is
governed by a BSD-style license that can be
nit: please also include BUG=686215 in the CL description

https://codereview.chromium.org/2692043009/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_popup_utils.cc:237:
views::CreateEmptyBorder(gfx::Insets(0, kTrayPopupSliderPaddingMD)));
On 2017/02/16 21:08:20, msw wrote:
> nit: drop 'MD' from constant (and move to this function, its only user?)

+1

[Evan Stade, 2017-02-16 22:47:05]

Description was changed from

==========
Remove last MD reference from TrayPopupUtils.

Remove NonMdSlider. Merge MdSlider and Slider.

BUG=686288
==========

to

==========
Remove last MD reference from TrayPopupUtils.

Remove NonMdSlider. Merge MdSlider and Slider.

BUG=686288,686215
==========

[Evan Stade, 2017-02-16 22:48:01]

https://codereview.chromium.org/2692043009/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/tray_popup_utils.cc (right):

https://codereview.chromium.org/2692043009/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_popup_utils.cc:2: // Use of this source code is
governed by a BSD-style license that can be
On 2017/02/16 22:03:50, tdanderson wrote:
> nit: please also include BUG=686215 in the CL description

Done.

https://codereview.chromium.org/2692043009/diff/40001/ash/common/system/tray/...
ash/common/system/tray/tray_popup_utils.cc:237:
views::CreateEmptyBorder(gfx::Insets(0, kTrayPopupSliderPaddingMD)));
On 2017/02/16 22:03:50, tdanderson wrote:
> On 2017/02/16 21:08:20, msw wrote:
> > nit: drop 'MD' from constant (and move to this function, its only user?)
> 
> +1

Done.

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/non_m...
File ui/views/controls/non_md_slider.cc (left):

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/non_m...
ui/views/controls/non_md_slider.cc:17: IDR_SLIDER_ACTIVE_LEFT,
IDR_SLIDER_ACTIVE_CENTER, IDR_SLIDER_PRESSED_CENTER,
On 2017/02/16 21:08:20, msw wrote:
> Please also remove the now unused IDR_SLIDER_* ids and associated images.

whoops. Thanks for catching.

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/slide...
File ui/views/controls/slider.cc (right):

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/slide...
ui/views/controls/slider.cc:82: SchedulePaint();
On 2017/02/16 21:08:20, msw wrote:
> q: needed? (presumably it'll schedule a paint when added to a view hier.)

yea, this is weird. I don't know why it's here (just copied from
MdSlider::MdSlider). +yiyix

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/slider.h
File ui/views/controls/slider.h (right):

https://codereview.chromium.org/2692043009/diff/40001/ui/views/controls/slide...
ui/views/controls/slider.h:99: void OnPaint(gfx::Canvas* canvas) override;
On 2017/02/16 21:08:20, msw wrote:
> nit: match order to view.h (btw GetAccessibleNodeData and OnFocus), ditto in
cc

Done.

[Evan Stade, 2017-02-16 22:48:07]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 22:49:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 00:43:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 00:43:38]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Evan Stade, 2017-02-17 21:07:05]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-02-17 21:07:06]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2692043009/#ps60001
(title: "review feedback")

[commit-bot: I haz the power, 2017-02-17 21:07:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:12:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Evan Stade, 2017-02-21 16:14:37]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-02-21 16:15:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 17:16:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 17:16:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-02-21 18:36:38]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-02-21 18:37:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 21:08:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:08:50]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2017-02-22 01:21:06]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:23:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 03:26:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:26:43]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Evan Stade, 2017-02-22 16:53:59]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-02-22 16:54:00]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2692043009/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-22 16:54:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 18:52:14]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487782439668820,
"parent_rev": "661aefbaac632bfaccfdb91a48242817de30a500", "commit_rev":
"66c91e5046e5f7430e4f62593a1fe5d6dfe347de"}

[commit-bot: I haz the power, 2017-02-22 18:52:52]

Description was changed from

==========
Remove last MD reference from TrayPopupUtils.

Remove NonMdSlider. Merge MdSlider and Slider.

BUG=686288,686215
==========

to

==========
Remove last MD reference from TrayPopupUtils.

Remove NonMdSlider. Merge MdSlider and Slider.

BUG=686288,686215

Review-Url: https://codereview.chromium.org/2692043009
Cr-Commit-Position: refs/heads/master@{#452148}
Committed:
https://chromium.googlesource.com/chromium/src/+/66c91e5046e5f7430e4f62593a1f...
==========

[commit-bot: I haz the power, 2017-02-22 18:52:54]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/66c91e5046e5f7430e4f62593a1f...