Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2692043008: Slightly tidy up the usage of SweepForbiddenScope and ScriptForbiddenScope (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Slightly tidy up the usage of SweepForbiddenScope and ScriptForbiddenScope SweepForbiddenScope and ScriptForbiddenScope are used together. This CL just makes it clearer in the code base. BUG=671856 Review-Url: https://codereview.chromium.org/2692043008 Cr-Commit-Position: refs/heads/master@{#450664} Committed: https://chromium.googlesource.com/chromium/src/+/df877d86769f52421f838b8b947569aabe80db6e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -39 lines) Patch
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 3 chunks +34 lines, -39 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
haraken
PTAL https://codereview.chromium.org/2692043008/diff/1/third_party/WebKit/Source/platform/heap/ThreadState.cpp File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right): https://codereview.chromium.org/2692043008/diff/1/third_party/WebKit/Source/platform/heap/ThreadState.cpp#newcode1279 third_party/WebKit/Source/platform/heap/ThreadState.cpp:1279: SweepForbiddenScope sweepForbidden(this); Actually this is not needed though.
3 years, 10 months ago (2017-02-15 09:37:15 UTC) #2
sof
lgtm, having ScriptForbiddenIfMainThreadScope now also apply across postGC() isn't problematic.
3 years, 10 months ago (2017-02-15 09:42:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692043008/1
3 years, 10 months ago (2017-02-15 09:46:25 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 11:18:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df877d86769f52421f838b8b9475...

Powered by Google App Engine
This is Rietveld 408576698