Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2692043006: mash: Work around startup crash in extensions::DisplayInfoProviderChromeOS (Closed)

Created:
3 years, 10 months ago by James Cook
Modified:
3 years, 10 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Work around startup crash in extensions::DisplayInfoProviderChromeOS The "Smart Lock" extension queries display information on login. This causes a browser crash attempting to access ash::Shell to get the DisplayManager. The crash is blocking enabling our desktopui_MashLogin autotest. For now, just early-exit all the calls on mash. BUG=682402 TEST=desktopui_MashLogin does not result in browser crash Review-Url: https://codereview.chromium.org/2692043006 Cr-Commit-Position: refs/heads/master@{#450522} Committed: https://chromium.googlesource.com/chromium/src/+/850f6feb8d0dc1a39dcc8ac63a91918a5c72a71d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M chrome/browser/extensions/display_info_provider_chromeos.cc View 11 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
James Cook
xiyuan, please take a look.
3 years, 10 months ago (2017-02-14 21:38:51 UTC) #2
xiyuan
lgtm Need an extension owner to take a look as well. Maybe rockot@?
3 years, 10 months ago (2017-02-14 21:55:39 UTC) #5
James Cook
rockot, can I get OWNERS?
3 years, 10 months ago (2017-02-14 22:03:00 UTC) #7
Ken Rockot(use gerrit already)
lgtm
3 years, 10 months ago (2017-02-14 22:03:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692043006/1
3 years, 10 months ago (2017-02-14 22:06:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/321744)
3 years, 10 months ago (2017-02-14 22:53:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692043006/1
3 years, 10 months ago (2017-02-14 23:11:28 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 00:10:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/850f6feb8d0dc1a39dcc8ac63a91...

Powered by Google App Engine
This is Rietveld 408576698