Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2692043002: Allow HostCache to handle network changes itself (Closed)

Created:
3 years, 10 months ago by mgersh
Modified:
3 years, 10 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow HostCache to handle network changes itself HostCache can already expire all of its entries when the network changes and return them only when entries from other networks are allowed. This change makes HostResolverImpl notify HostCache on network change instead of clearing it, and modifies the StaleHostResolver tests to simulate a network change using NetworkChangeNotifier rather than directly notifying HostCache so that the relevant codepath is tested. The addition of net_java in deps is necessary to use NetworkChangeNotifier on Android. This change finishes implementation of the "allow_other_networks" option in Cronet's "StaleDNS" experiment. BUG=691078 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2692043002 Cr-Commit-Position: refs/heads/master@{#450096} Committed: https://chromium.googlesource.com/chromium/src/+/5bb3b9d0c571ca00d511f36411a4dd06397b181f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M components/cronet/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/stale_host_resolver_unittest.cc View 4 chunks +11 lines, -4 lines 0 comments Download
M net/dns/host_resolver_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
mgersh
PTAL
3 years, 10 months ago (2017-02-13 18:01:36 UTC) #4
Julia Tuttle
On 2017/02/13 18:01:36, mgersh wrote: > PTAL lgtm
3 years, 10 months ago (2017-02-13 19:48:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692043002/1
3 years, 10 months ago (2017-02-13 19:52:23 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 21:27:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5bb3b9d0c571ca00d511f36411a4...

Powered by Google App Engine
This is Rietveld 408576698