Fix WebAPK renderer not launching

Fix WebAPK renderer not launching

WebApkSandboxedService creates ChildProcessServiceImpl via reflection.
https://codereview.chromium.org/2675013002 added a non public constructor to
ChildProcessServiceImpl causing construction-via-reflection to fail.

BUG=691709, 691724
Review-Url: https://codereview.chromium.org/2692023003
Cr-Commit-Position: refs/heads/master@{#450207}
Committed: https://chromium.googlesource.com/chromium/src/+/feb7ca146e6cd6662129d0b82dfe116b94d37ad1

[pkotwicz, 2017-02-13 22:07:50]

Description was changed from

==========
Fix WebAPK renderer not launching

WebApkSandboxedService creates ChildProcessServiceImpl via reflection.
https://codereview.chromium.org/2675013002 added a non public constructor to
ChildProcessServiceImpl causing construction-via-reflection to fail.

BUG=691709,691724
==========

to

==========
Fix WebAPK renderer not launching

WebApkSandboxedService creates ChildProcessServiceImpl via reflection.
https://codereview.chromium.org/2675013002 added a non public constructor to
ChildProcessServiceImpl causing construction-via-reflection to fail.

BUG=691709,691724
==========

[pkotwicz, 2017-02-13 22:07:50]

pkotwicz@chromium.org changed reviewers:
+ boliu@chromium.org

[pkotwicz, 2017-02-13 22:08:34]

boliu@ can you please take a look?

[boliu, 2017-02-13 22:16:32]

lgtm

Is reflection required to keep code private, or due to webapk technical reasons?
Either way, is there a bug to fix it?

[pkotwicz, 2017-02-13 23:10:21]

Reflection is required so that we can create the WebAPK's renderer in the
WebAPK's process instead of in the browser's process. I am unaware of a bug to
fix it. https://crbug.com/664530 is tangentially related

[boliu, 2017-02-13 23:16:57]

On 2017/02/13 23:10:21, pkotwicz wrote:
> Reflection is required so that we can create the WebAPK's renderer in the
> WebAPK's process instead of in the browser's process. I am unaware of a bug to
> fix it. https://crbug.com/664530 is tangentially related

it's required technically, then the fix is to have a cq bot covering this

and also refactoring all the reflections to a *single* class, so that
UsedByReflection is not sprinkled all over the place

[pkotwicz, 2017-02-14 01:53:05]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-02-14 01:53:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 02:37:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487037185329490, "parent_rev":
"b190459e78a61ae6000cd5c8fde6464d29171183", "commit_rev":
"feb7ca146e6cd6662129d0b82dfe116b94d37ad1"}

[commit-bot: I haz the power, 2017-02-14 02:38:52]

Description was changed from

==========
Fix WebAPK renderer not launching

WebApkSandboxedService creates ChildProcessServiceImpl via reflection.
https://codereview.chromium.org/2675013002 added a non public constructor to
ChildProcessServiceImpl causing construction-via-reflection to fail.

BUG=691709,691724
==========

to

==========
Fix WebAPK renderer not launching

WebApkSandboxedService creates ChildProcessServiceImpl via reflection.
https://codereview.chromium.org/2675013002 added a non public constructor to
ChildProcessServiceImpl causing construction-via-reflection to fail.

BUG=691709,691724

Review-Url: https://codereview.chromium.org/2692023003
Cr-Commit-Position: refs/heads/master@{#450207}
Committed:
https://chromium.googlesource.com/chromium/src/+/feb7ca146e6cd6662129d0b82dfe...
==========

[commit-bot: I haz the power, 2017-02-14 02:38:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/feb7ca146e6cd6662129d0b82dfe...