Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2692003002: Fix disabling of FileSystemProviderApiTest.ReadFile (Closed)

Created:
3 years, 10 months ago by msramek
Modified:
3 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix disabling of FileSystemProviderApiTest.ReadFile In https://codereview.chromium.org/2689193002, this test was disabled everywhere except ChromeOS. Instead, it should have been disabled on ChromiumOS. NOTRY=True TBR=mtomasz@chromium.org BUG=691449 Review-Url: https://codereview.chromium.org/2692003002 Cr-Commit-Position: refs/heads/master@{#449968} Committed: https://chromium.googlesource.com/chromium/src/+/54520ce5e56cd898668f0f86172cdeb9914a9b71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692003002/1
3 years, 10 months ago (2017-02-13 16:04:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/54520ce5e56cd898668f0f86172cdeb9914a9b71
3 years, 10 months ago (2017-02-13 16:09:31 UTC) #5
tyoshino (SeeGerritForStatus)
3 years, 10 months ago (2017-02-14 01:48:07 UTC) #6
Message was sent while issue was closed.
On 2017/02/13 16:09:31, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/54520ce5e56cd898668f0f86172c...

lgtm

Thanks for fixing it. My bad!

Powered by Google App Engine
This is Rietveld 408576698