Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2691953003: [WPT Export] Remove all newlines in GitHub auth header (Closed)

Created:
3 years, 10 months ago by jeffcarp
Modified:
3 years, 10 months ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WPT Export] Remove all newlines in GitHub auth header BUG= Review-Url: https://codereview.chromium.org/2691953003 Cr-Commit-Position: refs/heads/master@{#450174} Committed: https://chromium.googlesource.com/chromium/src/+/969343d2c18b8ef33413c4bdd86490d245510b1d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change base64.encodestring to base64.b64encode to fix newline problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jeffcarp
Trying out the new GitHub bot, this was causing issues.
3 years, 10 months ago (2017-02-13 22:04:14 UTC) #2
qyearsley
https://codereview.chromium.org/2691953003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py (right): https://codereview.chromium.org/2691953003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py#newcode25 third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py:25: return base64.encodestring('{}:{}'.format(self.user, self.token)).replace('\n', '') Or, as just discussed: base64.b64encode('{}:{}'.format(self.user, ...
3 years, 10 months ago (2017-02-13 23:29:12 UTC) #3
qyearsley
lgtm
3 years, 10 months ago (2017-02-13 23:33:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691953003/20001
3 years, 10 months ago (2017-02-13 23:34:25 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 00:41:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/969343d2c18b8ef33413c4bdd864...

Powered by Google App Engine
This is Rietveld 408576698