Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2691943009: Remove unused blink_gc_plugin_flags.py script. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused blink_gc_plugin_flags.py script. Became unused with GN, now safe to remove. R=dcheng,thakis BUG= Review-Url: https://codereview.chromium.org/2691943009 Cr-Commit-Position: refs/heads/master@{#451056} Committed: https://chromium.googlesource.com/chromium/src/+/114b2d6f5b9ce2206987fa8db489e2d2d05581b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
D tools/clang/scripts/blink_gc_plugin_flags.py View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look.
3 years, 10 months ago (2017-02-16 09:22:03 UTC) #2
dcheng
LGTM
3 years, 10 months ago (2017-02-16 09:23:09 UTC) #5
Nico
lgtm
3 years, 10 months ago (2017-02-16 13:00:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691943009/1
3 years, 10 months ago (2017-02-16 19:14:41 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 19:41:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/114b2d6f5b9ce2206987fa8db489...

Powered by Google App Engine
This is Rietveld 408576698