Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2691943003: Disable test in cc_perftest (Closed)

Created:
3 years, 10 months ago by martiniss
Modified:
3 years, 10 months ago
Reviewers:
jbudorick, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable test in cc_perftest Disable DelegatedFrame_ManyQuads_10_100000 on android. The test is taking too long. BUG=691730 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2691943003 Cr-Commit-Position: refs/heads/master@{#450130} Committed: https://chromium.googlesource.com/chromium/src/+/0dbe48ffd68565abfb1eb87dc922fe6fcc47b35d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment about reason for disabling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M cc/ipc/cc_serialization_perftest.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
martiniss
PTAL
3 years, 10 months ago (2017-02-13 22:26:47 UTC) #3
martiniss
Adding OWNER
3 years, 10 months ago (2017-02-13 22:27:30 UTC) #5
jbudorick
lgtm w/ nit https://codereview.chromium.org/2691943003/diff/1/cc/ipc/cc_serialization_perftest.cc File cc/ipc/cc_serialization_perftest.cc (right): https://codereview.chromium.org/2691943003/diff/1/cc/ipc/cc_serialization_perftest.cc#newcode289 cc/ipc/cc_serialization_perftest.cc:289: #if defined(OS_ANDROID) nit: Add a comment ...
3 years, 10 months ago (2017-02-13 22:29:31 UTC) #6
weiliangc
Thanks for doing this. LGTM.
3 years, 10 months ago (2017-02-13 22:32:26 UTC) #7
martiniss
https://codereview.chromium.org/2691943003/diff/1/cc/ipc/cc_serialization_perftest.cc File cc/ipc/cc_serialization_perftest.cc (right): https://codereview.chromium.org/2691943003/diff/1/cc/ipc/cc_serialization_perftest.cc#newcode289 cc/ipc/cc_serialization_perftest.cc:289: #if defined(OS_ANDROID) On 2017/02/13 at 22:29:30, jbudorick wrote: > ...
3 years, 10 months ago (2017-02-13 22:35:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691943003/20001
3 years, 10 months ago (2017-02-13 22:36:32 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 22:50:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0dbe48ffd68565abfb1eb87dc922...

Powered by Google App Engine
This is Rietveld 408576698