Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: components/favicon/content/content_favicon_driver.h

Issue 2691933004: Avoid cyclic dependency FaviconHandler<-->FaviconDriverImpl (Closed)
Patch Set: Minor fix. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/content/content_favicon_driver.h
diff --git a/components/favicon/content/content_favicon_driver.h b/components/favicon/content/content_favicon_driver.h
index 75f5dbee954a68fab735256ecd4f055877038fb8..4b1b79b65ada76ce315cccc319af3d49c59b7fc2 100644
--- a/components/favicon/content/content_favicon_driver.h
+++ b/components/favicon/content/content_favicon_driver.h
@@ -45,8 +45,6 @@ class ContentFaviconDriver
// FaviconDriver implementation.
gfx::Image GetFavicon() const override;
bool FaviconIsValid() const override;
- int StartDownload(const GURL& url, int max_bitmap_size) override;
- bool IsOffTheRecord() override;
GURL GetActiveURL() override;
protected:
@@ -59,13 +57,16 @@ class ContentFaviconDriver
private:
friend class content::WebContentsUserData<ContentFaviconDriver>;
- // FaviconDriver implementation.
- void OnFaviconUpdated(
- const GURL& page_url,
- FaviconDriverObserver::NotificationIconType icon_type,
- const GURL& icon_url,
- bool icon_url_changed,
- const gfx::Image& image) override;
+ // FaviconHandler::Delegate implementation.
+ int DownloadImage(const GURL& url,
+ int max_image_size,
+ ImageDownloadCallback callback) override;
+ bool IsOffTheRecord() override;
+ void OnFaviconUpdated(const GURL& page_url,
+ FaviconDriverObserver::NotificationIconType icon_type,
+ const GURL& icon_url,
+ bool icon_url_changed,
+ const gfx::Image& image) override;
// content::WebContentsObserver implementation.
void DidUpdateFaviconURL(

Powered by Google App Engine
This is Rietveld 408576698