Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2691883002: Uprefix CSS transitions in ui/ and chrome/ styles (Closed)

Created:
3 years, 10 months ago by Eric Willigers
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam, sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, posciak+watch_chromium.org, skanuj+watch_chromium.org, yusukes+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, shuchen+watch_chromium.org, oka+watch_chromium.org, dcheng, rginda+watch_chromium.org, bnc+watch_chromium.org, arv+watch_chromium.org, fukino+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, aboxhall+watch_chromium.org, sebsg+autofillwatch_chromium.org, achuith+watch_chromium.org, Patrick Dubroy, nona+watch_chromium.org, je_julie, devtools-reviews_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, alemate+watch_chromium.org, samarth+watch_chromium.org, rouslan+autofill_chromium.org, yamaguchi+watch_chromium.org, yuzo+watch_chromium.org, michaelpg+watch-md-ui_chromium.org, jfweitz+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, mtomasz+watch_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, Jered, rogerm+autofillwatch_chromium.org, michaelpg+watch-options_chromium.org, mathp+autofillwatch_chromium.org, tfarina, donnd+watch_chromium.org, nektar+watch_chromium.org, dbeam+watch-history_chromium.org, eroman, David Black, mmenke, dtseng+watch_chromium.org, kmadhusu+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, pfeldman, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Uprefix CSS transitions in ui/ and chrome/ styles Transitions no longer require webkit prefix. BUG=668650 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2691883002 Cr-Commit-Position: refs/heads/master@{#451402} Committed: https://chromium.googlesource.com/chromium/src/+/63f826afd2936707c9c697ce774a65e783041db7

Patch Set 1 #

Patch Set 2 : transitions only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -253 lines) Patch
M chrome/browser/devtools/frontend/devtools_discovery_page.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/bluetooth_internals/snackbar.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/bookmark_manager/css/bmm.css View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/active_indicator.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/braille_overlay_widget.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/search_widget.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/first_run/first_run.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/header_bar.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/header_bar.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/network_dropdown.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_popup_overlay.css View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen.css View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.css View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_app_launch_splash.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_app_launch_splash.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_supervised_user_creation.css View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/neterror.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/components.css View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/extensions/chromeos/kiosk_apps.css View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/help/help_content.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/help/help_page.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/history/history.css View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/history/history.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/history/history_mobile.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/inspect/inspect.css View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/local_ntp/local_ntp.css View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/local_ntp/local_ntp.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_single.css View 1 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_single.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/net_internals/hsts_view.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/ntp4/apps_page.css View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/nav_dot.css View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/ntp4/nav_dot.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab.css View 1 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/ntp4/tile_page.css View 1 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/ntp4/tile_page.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/browser_options.css View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/chromeos/change_picture_options.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/cookies_view.css View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/handler_options.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/language_options.css View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.css View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options_page.css View 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/password_manager_list.css View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/supervised_user_import.css View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/sync_setup_overlay.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/common/overlay.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/previewarea/margin_control.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/previewarea/margin_control.js View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/previewarea/preview_area.css View 1 chunk +13 lines, -13 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.css View 1 6 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview_animations.js View 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/print_preview/search/destination_list_item.css View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/search/fedex_tos.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/set_as_default_browser.css View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/supervised_user_internals.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/uber/uber.css View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/uber/uber.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/uber/uber_frame.css View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_browsertest.js View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/accessibility/extensions/caretbrowsing/caretbrowsing.js View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/tree.css View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/css/gallery.css View 1 2 chunks +1 line, -1 line 0 comments Download
M ui/login/account_picker/screen_account_picker.css View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/login/account_picker/screen_account_picker.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/login/account_picker/user_pod_row.css View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/login/bubble.css View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/login/bubble.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/login/display_manager.js View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/login/oobe.css View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/login/screen_container.css View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ui/webui/resources/css/chrome_shared.css View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/webui/resources/css/dialogs.css View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ui/webui/resources/css/overlay.css View 1 4 chunks +3 lines, -3 lines 0 comments Download
M ui/webui/resources/css/tabs.css View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/webui/resources/css/trash.css View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/webui/resources/css/tree.css View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/webui/resources/css/widgets.css View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/webui/resources/js/cr/ui/card_slider.js View 4 chunks +6 lines, -6 lines 0 comments Download
M ui/webui/resources/js/cr/ui/page_manager/page.js View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/webui/resources/js/util.js View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 32 (22 generated)
Eric Willigers
The changelists https://codereview.chromium.org/2535573002/ https://codereview.chromium.org/2535493002/ are failing individually. This changelist is to determine if such CLs ...
3 years, 10 months ago (2017-02-13 03:17:43 UTC) #5
Eric Willigers
On 2017/02/13 03:17:43, Eric Willigers wrote: > The changelists > https://codereview.chromium.org/2535573002/ > https://codereview.chromium.org/2535493002/ > are ...
3 years, 10 months ago (2017-02-15 03:47:58 UTC) #14
Eric Willigers
3 years, 10 months ago (2017-02-15 04:44:08 UTC) #17
Dan Beam
rs lgtm
3 years, 10 months ago (2017-02-17 06:36:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691883002/40001
3 years, 10 months ago (2017-02-17 06:39:35 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/367003)
3 years, 10 months ago (2017-02-17 06:50:42 UTC) #24
Eric Willigers
+sky for ui/OWNERS and chrome/browser/devtools/frontend/devtools_discovery_page.html OWNERS CSS transforms and CSS animations have previously been unprefixed ...
3 years, 10 months ago (2017-02-17 20:35:33 UTC) #26
sky
LGTM
3 years, 10 months ago (2017-02-17 22:26:47 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691883002/40001
3 years, 10 months ago (2017-02-17 22:33:59 UTC) #29
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 23:48:33 UTC) #32
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/63f826afd2936707c9c697ce774a...

Powered by Google App Engine
This is Rietveld 408576698