Animations: Smooth interpolation for rotate none

Animations: Smooth interpolation for rotate none

When rotate is animating or transitioning, and
the from value or to value (but not both) is none,
the value none is replaced by the equivalent
identity value: 0deg

https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG=679873
Review-Url: https://codereview.chromium.org/2691863002
Cr-Commit-Position: refs/heads/master@{#449910}
Committed: https://chromium.googlesource.com/chromium/src/+/1f37ab2e5576e8ce57c0eb58e412c65f0b66021b

[Eric Willigers, 2017-02-12 22:30:42]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 22:30:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-02-12 22:31:25]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[Eric Willigers, 2017-02-12 22:31:26]

An alternate approach would be to use NaN to represent 'none'.

Using a bool is more explicit.

[commit-bot: I haz the power, 2017-02-12 23:47:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 23:47:37]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-02-13 02:56:55]

lgtm after comments addressed.

https://codereview.chromium.org/2691863002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
(right):

https://codereview.chromium.org/2691863002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp:18: :
m_rotation(Rotation(FloatPoint3D(0, 0, 1), 0)), m_isNone(true) {}
Just use Rotation's default constructor, its value is meaningless here anyway.

https://codereview.chromium.org/2691863002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp:24:
Rotation rotation() const {
Return const ref.

https://codereview.chromium.org/2691863002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp:42:
return OptionalRotation();
For all other cases just get a from and to Rotation via ternaries and have a
single slerp() call.

[Eric Willigers, 2017-02-13 03:02:23]

https://codereview.chromium.org/2691863002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
(right):

https://codereview.chromium.org/2691863002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp:18: :
m_rotation(Rotation(FloatPoint3D(0, 0, 1), 0)), m_isNone(true) {}
On 2017/02/13 02:56:55, alancutter wrote:
> Just use Rotation's default constructor, its value is meaningless here anyway.

Done.

https://codereview.chromium.org/2691863002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp:24:
Rotation rotation() const {
On 2017/02/13 02:56:55, alancutter wrote:
> Return const ref.

Done.

https://codereview.chromium.org/2691863002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp:42:
return OptionalRotation();
On 2017/02/13 02:56:55, alancutter wrote:
> For all other cases just get a from and to Rotation via ternaries and have a
> single slerp() call.

Done.

[alancutter (OOO until 2018), 2017-02-13 03:29:36]

https://codereview.chromium.org/2691863002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
(right):

https://codereview.chromium.org/2691863002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp:17:
OptionalRotation() : m_rotation(Rotation()), m_isNone(true) {}
No need to call the copy constructor here, just omit the member variable
altogether.

[Eric Willigers, 2017-02-13 03:59:43]

https://codereview.chromium.org/2691863002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
(right):

https://codereview.chromium.org/2691863002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp:17:
OptionalRotation() : m_rotation(Rotation()), m_isNone(true) {}
On 2017/02/13 03:29:36, alancutter wrote:
> No need to call the copy constructor here, just omit the member variable
> altogether.

Done.

[Eric Willigers, 2017-02-13 03:59:58]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 04:00:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 05:27:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 05:27:13]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2017-02-13 05:28:49]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-02-13 05:28:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2691863002/#ps40001
(title: "review feedback")

[commit-bot: I haz the power, 2017-02-13 05:29:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 05:32:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486963729617280,
"parent_rev": "df183ec6ada211dda086eda5b3bb940f7802ca9f", "commit_rev":
"1f37ab2e5576e8ce57c0eb58e412c65f0b66021b"}

[commit-bot: I haz the power, 2017-02-13 05:33:20]

Description was changed from

==========
Animations: Smooth interpolation for rotate none

When rotate is animating or transitioning, and
the from value or to value (but not both) is none,
the value none is replaced by the equivalent
identity value: 0deg

https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG=679873
==========

to

==========
Animations: Smooth interpolation for rotate none

When rotate is animating or transitioning, and
the from value or to value (but not both) is none,
the value none is replaced by the equivalent
identity value: 0deg

https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG=679873

Review-Url: https://codereview.chromium.org/2691863002
Cr-Commit-Position: refs/heads/master@{#449910}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f37ab2e5576e8ce57c0eb58e412...
==========

[commit-bot: I haz the power, 2017-02-13 05:33:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1f37ab2e5576e8ce57c0eb58e412...