Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: components/metrics/serialization/serialization_utils.h

Issue 2691803002: Remove ScopedVector in //component/metrics (Closed)
Patch Set: code rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/serialization/serialization_utils.h
diff --git a/components/metrics/serialization/serialization_utils.h b/components/metrics/serialization/serialization_utils.h
index 202f89c8aad247a76bd094d2c06c12bbc5a7a507..c741cb2f29880c151e309b281394812081e7c5db 100644
--- a/components/metrics/serialization/serialization_utils.h
+++ b/components/metrics/serialization/serialization_utils.h
@@ -7,8 +7,7 @@
#include <memory>
#include <string>
-
-#include "base/memory/scoped_vector.h"
+#include <vector>
namespace metrics {
@@ -24,8 +23,9 @@ namespace SerializationUtils {
std::unique_ptr<MetricSample> ParseSample(const std::string& sample);
// Reads all samples from a file and truncate the file when done.
-void ReadAndTruncateMetricsFromFile(const std::string& filename,
- ScopedVector<MetricSample>* metrics);
+void ReadAndTruncateMetricsFromFile(
+ const std::string& filename,
+ std::vector<std::unique_ptr<MetricSample>>* metrics);
// Serializes a sample and write it to filename.
// The format for the message is:
« no previous file with comments | « components/metrics/metrics_service_unittest.cc ('k') | components/metrics/serialization/serialization_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698