Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: components/metrics/serialization/serialization_utils.cc

Issue 2691803002: Remove ScopedVector in //component/metrics (Closed)
Patch Set: code rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/serialization/serialization_utils.cc
diff --git a/components/metrics/serialization/serialization_utils.cc b/components/metrics/serialization/serialization_utils.cc
index e9ae83e0a0bfc4ebe582394341fb52ab635e6772..39290a471de7ce53c48335252a091b5113b1b6de 100644
--- a/components/metrics/serialization/serialization_utils.cc
+++ b/components/metrics/serialization/serialization_utils.cc
@@ -8,16 +8,12 @@
#include <stdint.h>
#include <sys/file.h>
-#include <memory>
-#include <string>
#include <utility>
-#include <vector>
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_file.h"
#include "base/logging.h"
-#include "base/memory/scoped_vector.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "components/metrics/serialization/metric_sample.h"
@@ -125,7 +121,7 @@ std::unique_ptr<MetricSample> SerializationUtils::ParseSample(
void SerializationUtils::ReadAndTruncateMetricsFromFile(
const std::string& filename,
- ScopedVector<MetricSample>* metrics) {
+ std::vector<std::unique_ptr<MetricSample>>* metrics) {
struct stat stat_buf;
int result;

Powered by Google App Engine
This is Rietveld 408576698