Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: components/metrics/metrics_log.h

Issue 2691803002: Remove ScopedVector in //component/metrics (Closed)
Patch Set: code rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/daily_event.cc ('k') | components/metrics/metrics_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_log.h
diff --git a/components/metrics/metrics_log.h b/components/metrics/metrics_log.h
index fb4bef2b9d7dcafe61dce481adb60c6f58c1b9e5..5a01964a05d9ae68bc5a314ff3cf9fc390643605 100644
--- a/components/metrics/metrics_log.h
+++ b/components/metrics/metrics_log.h
@@ -10,6 +10,7 @@
#include <stdint.h>
+#include <memory>
#include <string>
#include <vector>
@@ -95,7 +96,7 @@ class MetricsLog {
// synthetic trial such that the group is determined by the pref value. The
// current environment is returned serialized as a string.
std::string RecordEnvironment(
- const std::vector<MetricsProvider*>& metrics_providers,
+ const std::vector<std::unique_ptr<MetricsProvider>>& metrics_providers,
const std::vector<variations::ActiveGroupId>& synthetic_trials,
int64_t install_date,
int64_t metrics_reporting_enabled_date);
@@ -116,13 +117,13 @@ class MetricsLog {
// as number of incomplete shutdowns as well as extra breakpad and debugger
// stats.
void RecordStabilityMetrics(
- const std::vector<MetricsProvider*>& metrics_providers,
+ const std::vector<std::unique_ptr<MetricsProvider>>& metrics_providers,
base::TimeDelta incremental_uptime,
base::TimeDelta uptime);
// Records general metrics based on the specified |metrics_providers|.
void RecordGeneralMetrics(
- const std::vector<MetricsProvider*>& metrics_providers);
+ const std::vector<std::unique_ptr<MetricsProvider>>& metrics_providers);
// Stop writing to this record and generate the encoded representation.
// None of the Record* methods can be called after this is called.
« no previous file with comments | « components/metrics/daily_event.cc ('k') | components/metrics/metrics_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698