Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: components/metrics/metrics_log.cc

Issue 2691803002: Remove ScopedVector in //component/metrics (Closed)
Patch Set: code rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/metrics_log.h ('k') | components/metrics/metrics_log_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_log.cc
diff --git a/components/metrics/metrics_log.cc b/components/metrics/metrics_log.cc
index 599376dce0376db84c1b6fcc376c0a3cadc312b7..e2740cb2410c4a73fbdbb643047f342586a309ae 100644
--- a/components/metrics/metrics_log.cc
+++ b/components/metrics/metrics_log.cc
@@ -7,9 +7,7 @@
#include <stddef.h>
#include <algorithm>
-#include <memory>
#include <string>
-#include <vector>
#include "base/base64.h"
#include "base/build_time.h"
@@ -205,7 +203,7 @@ void MetricsLog::RecordHistogramDelta(const std::string& histogram_name,
}
void MetricsLog::RecordStabilityMetrics(
- const std::vector<MetricsProvider*>& metrics_providers,
+ const std::vector<std::unique_ptr<MetricsProvider>>& metrics_providers,
base::TimeDelta incremental_uptime,
base::TimeDelta uptime) {
DCHECK(!closed_);
@@ -301,7 +299,7 @@ void MetricsLog::RecordStabilityMetrics(
}
void MetricsLog::RecordGeneralMetrics(
- const std::vector<MetricsProvider*>& metrics_providers) {
+ const std::vector<std::unique_ptr<MetricsProvider>>& metrics_providers) {
if (local_state_->GetBoolean(prefs::kMetricsResetIds))
UMA_HISTOGRAM_BOOLEAN("UMA.IsClonedInstall", true);
@@ -384,7 +382,7 @@ void MetricsLog::WriteRealtimeStabilityAttributes(
}
std::string MetricsLog::RecordEnvironment(
- const std::vector<MetricsProvider*>& metrics_providers,
+ const std::vector<std::unique_ptr<MetricsProvider>>& metrics_providers,
const std::vector<variations::ActiveGroupId>& synthetic_trials,
int64_t install_date,
int64_t metrics_reporting_enabled_date) {
« no previous file with comments | « components/metrics/metrics_log.h ('k') | components/metrics/metrics_log_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698