Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 26918002: Original review https://codereview.chromium.org/25855005. (Closed)

Created:
7 years, 2 months ago by Nebojša Ćirić
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Original review https://codereview.chromium.org/25855005. Reverting reverted r17148 and fixing build (test) breakage by side stepping the Windows vs. Linux issue of different Date object for the same millisecond time stamp. We do that by using UTC Date methods (they eliminate DST problems). Windows: new Date(129193200000); Sun Feb 03 1974 23:00:00 GMT-0800 (Pacific Standard Time) Linux: new Date(129193200000); Mon Feb 04 1974 00:00:00 GMT-0700 (PST) BUG=2919 R=dslomov@chromium.org, mnita@google.com Committed: https://code.google.com/p/v8/source/detail?r=17171

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -90 lines) Patch
M src/i18n.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/intl/date-format/parse-MMMdy.js View 1 chunk +9 lines, -6 lines 0 comments Download
M test/intl/date-format/parse-mdy.js View 1 chunk +17 lines, -15 lines 0 comments Download
M test/intl/date-format/parse-mdyhms.js View 1 chunk +14 lines, -8 lines 0 comments Download
A + test/intl/date-format/timezone-name.js View 1 chunk +19 lines, -21 lines 0 comments Download
D test/intl/date-format/utils.js View 1 chunk +0 lines, -36 lines 0 comments Download
M test/intl/testcfg.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nebojša Ćirić
Dmitry, this is the same CL you reverted with small fix in: test/intl/date-format/parse-mdy.js test/intl/date-format/parse-MMMdy.js We ...
7 years, 2 months ago (2013-10-10 20:54:16 UTC) #1
mnita
On 2013/10/10 20:54:16, Nebojša Ćirić wrote: > Dmitry, this is the same CL you reverted ...
7 years, 2 months ago (2013-10-10 21:13:34 UTC) #2
Dmitry Lomov (no reviews)
lgtm
7 years, 2 months ago (2013-10-11 10:03:47 UTC) #3
Nebojša Ćirić
7 years, 2 months ago (2013-10-11 17:54:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r17171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698