Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Issue 25855005: Fixing timezone issues with date-time/parse-* tests. (Closed)

Created:
7 years, 2 months ago by Nebojša Ćirić
Modified:
7 years, 2 months ago
CC:
v8-dev, mnita, yurys
Visibility:
Public.

Description

Fixing timezone issues with date-time/parse-* tests. BUG=2919 TEST=All tests passing when local timezone was set to EST. R=mnita@google.com, titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17148

Patch Set 1 #

Patch Set 2 : Updating testcfg.py so it doesn't load deleted utils.js file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -91 lines) Patch
M src/i18n.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/intl/date-format/parse-MMMdy.js View 1 chunk +9 lines, -6 lines 1 comment Download
M test/intl/date-format/parse-mdy.js View 1 chunk +17 lines, -15 lines 1 comment Download
M test/intl/date-format/parse-mdyhms.js View 1 chunk +14 lines, -8 lines 0 comments Download
A + test/intl/date-format/timezone-name.js View 1 chunk +19 lines, -22 lines 0 comments Download
D test/intl/date-format/utils.js View 1 chunk +0 lines, -36 lines 0 comments Download
M test/intl/testcfg.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nebojša Ćirić
This will make the tests stable. I tested it with local timezone set to EST ...
7 years, 2 months ago (2013-10-04 17:55:04 UTC) #1
Nebojša Ćirić
On 2013/10/04 17:55:04, Nebojša Ćirić wrote: > This will make the tests stable. I tested ...
7 years, 2 months ago (2013-10-07 23:12:54 UTC) #2
Nebojša Ćirić
This time real Jochen :)
7 years, 2 months ago (2013-10-08 16:51:12 UTC) #3
mnita
lgtm Two files use non-UTC methods to access date fields. Nothing wrong, but probably nicer ...
7 years, 2 months ago (2013-10-08 20:04:40 UTC) #4
Nebojša Ćirić
I wanted to test non-UTC time zone for better code coverage. Also, this is February ...
7 years, 2 months ago (2013-10-08 21:14:07 UTC) #5
titzer
lgtm
7 years, 2 months ago (2013-10-10 09:38:13 UTC) #6
Nebojša Ćirić
7 years, 2 months ago (2013-10-10 17:54:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r17148 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698