Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: pkg/analyzer_plugin/test/integration/support/integration_tests.dart

Issue 2691763002: Add integration tests for the execution domain. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_plugin/test/integration/support/integration_tests.dart
diff --git a/pkg/analyzer_plugin/test/integration/support/integration_tests.dart b/pkg/analyzer_plugin/test/integration/support/integration_tests.dart
index 46200d4236bea66e5a1bd97cf38437da831e0681..a8f4e89c98860f2fa73f933880209d10a293de5d 100644
--- a/pkg/analyzer_plugin/test/integration/support/integration_tests.dart
+++ b/pkg/analyzer_plugin/test/integration/support/integration_tests.dart
@@ -558,9 +558,7 @@ class Server {
_pendingCommands.remove(id);
}
if (messageAsMap.containsKey('error')) {
- // TODO(paulberry): propagate the error info to the completer.
- completer.completeError(new UnimplementedError(
- 'Server responded with an error: ${JSON.encode(message)}'));
+ completer.completeError(messageAsMap['error']);
Paul Berry 2017/02/12 14:39:04 Hmm, when did this code get duplicated? We should
Brian Wilkerson 2017/02/12 16:41:54 It was duplicated when I created the analyzer_plug
devoncarew 2017/02/12 17:52:34 Is it important to keep this files in sync? If so,
Brian Wilkerson 2017/02/12 18:47:09 That depends on what you mean by "important". :-)
} else {
completer.complete(messageAsMap['result']);
}

Powered by Google App Engine
This is Rietveld 408576698