Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: pkg/analysis_server/test/integration/integration_tests.dart

Issue 2691763002: Add integration tests for the execution domain. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/integration_tests.dart
diff --git a/pkg/analysis_server/test/integration/integration_tests.dart b/pkg/analysis_server/test/integration/integration_tests.dart
index d277f2cf0d27efeccd27c5988fd20959a275c151..7f7bd74ca95a8dafe16f0fd3df75888fb51968fd 100644
--- a/pkg/analysis_server/test/integration/integration_tests.dart
+++ b/pkg/analysis_server/test/integration/integration_tests.dart
@@ -577,9 +577,7 @@ class Server {
_pendingCommands.remove(id);
}
if (messageAsMap.containsKey('error')) {
- // TODO(paulberry): propagate the error info to the completer.
- completer.completeError(new UnimplementedError(
- 'Server responded with an error: ${JSON.encode(message)}'));
+ completer.completeError(messageAsMap['error']);
Paul Berry 2017/02/12 14:39:04 I'd recommend making a new class which represents
devoncarew 2017/02/12 17:52:34 Done.
} else {
completer.complete(messageAsMap['result']);
}

Powered by Google App Engine
This is Rietveld 408576698