Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2691693003: MD WebUI: avoid double-loading i18nTemplate when unvulcanized (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: avoid double-loading i18nTemplate when unvulcanized R=dpapad@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2691693003 Cr-Commit-Position: refs/heads/master@{#449876} Committed: https://chromium.googlesource.com/chromium/src/+/837468374c21fe8d2e6563531f8dbc1b6cf0d1de

Patch Set 1 : asdf #

Patch Set 2 : webui_resources.grd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M ui/webui/resources/html/i18n_template.html View 1 chunk +2 lines, -1 line 0 comments Download
M ui/webui/resources/js/i18n_template.js View 1 chunk +5 lines, -2 lines 0 comments Download
A + ui/webui/resources/js/i18n_template_process.js View 1 chunk +1 line, -3 lines 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Dan Beam
3 years, 10 months ago (2017-02-11 02:32:59 UTC) #3
dpapad
LGTM. I tried locally with the changes in https://codereview.chromium.org/2573943002 and it worked (both use_vulcanize true ...
3 years, 10 months ago (2017-02-11 02:48:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691693003/40001
3 years, 10 months ago (2017-02-11 02:49:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/280544) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 10 months ago (2017-02-11 03:19:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691693003/40001
3 years, 10 months ago (2017-02-11 20:55:25 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 21:33:34 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/837468374c21fe8d2e6563531f8d...

Powered by Google App Engine
This is Rietveld 408576698