Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2691653002: Improve postscript language level detection (Closed)

Created:
3 years, 10 months ago by rbpotter
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve postscript language level detection Improve language level detection by setting printer mode to Postscript if it is identified as postscript before performing any other ExtEscape commands. Change PASSTHROUGH to POSTSCRIPT_PASSTHROUGH since normal PASSTHROUGH is not supported in PS mode. BUG=614988 Review-Url: https://codereview.chromium.org/2691653002 Cr-Commit-Position: refs/heads/master@{#449749} Committed: https://chromium.googlesource.com/chromium/src/+/54f7fa845c0e48f14955b46d83ccff44f90281da

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M chrome/browser/printing/pdf_to_emf_converter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M printing/print_settings_initializer_win.cc View 4 chunks +18 lines, -5 lines 2 comments Download

Messages

Total messages: 17 (11 generated)
rbpotter
3 years, 10 months ago (2017-02-10 21:03:54 UTC) #5
Vitaly Buka (NO REVIEWS)
lgtm
3 years, 10 months ago (2017-02-10 21:15:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691653002/1
3 years, 10 months ago (2017-02-10 21:58:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/54f7fa845c0e48f14955b46d83ccff44f90281da
3 years, 10 months ago (2017-02-10 22:06:29 UTC) #13
Lei Zhang
https://codereview.chromium.org/2691653002/diff/1/printing/print_settings_initializer_win.cc File printing/print_settings_initializer_win.cc (left): https://codereview.chromium.org/2691653002/diff/1/printing/print_settings_initializer_win.cc#oldcode40 printing/print_settings_initializer_win.cc:40: // Query the PS Level if possible. Many PS ...
3 years, 10 months ago (2017-02-25 02:49:50 UTC) #16
rbpotter
3 years, 9 months ago (2017-02-27 16:58:48 UTC) #17
Message was sent while issue was closed.
On 2017/02/25 02:49:50, Lei Zhang (super slow) wrote:
>
https://codereview.chromium.org/2691653002/diff/1/printing/print_settings_ini...
> File printing/print_settings_initializer_win.cc (left):
> 
>
https://codereview.chromium.org/2691653002/diff/1/printing/print_settings_ini...
> printing/print_settings_initializer_win.cc:40: // Query the PS Level if
> possible. Many PS printers do not implement this.
> Are there printers that only support this in PS mode or something?
> 
>
https://codereview.chromium.org/2691653002/diff/1/printing/print_settings_ini...
> File printing/print_settings_initializer_win.cc (right):
> 
>
https://codereview.chromium.org/2691653002/diff/1/printing/print_settings_ini...
> printing/print_settings_initializer_win.cc:27: if (strcmp(technology,
> "PostScript") == 0 &&
> Doing this within IsTechnology() seems weird, but it looks like we are going
to
> fix it in https://codereview.chromium.org/2714073002/.

Yes, most printers only support the postscript level function in PS (or GDI)
mode.

New patch fixes the IsTechnology() issue.

Powered by Google App Engine
This is Rietveld 408576698