Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 269163004: don't leak the bitmapShader (Closed)

Created:
6 years, 7 months ago by reed1
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

don't leak the bitmapShader BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkPictureShader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
reed1
6 years, 7 months ago (2014-05-06 13:17:10 UTC) #1
reed1
Down in the constructor for pictureshadercontext, we (correctly) SkRef the shader, but the caller was ...
6 years, 7 months ago (2014-05-06 13:17:50 UTC) #2
robertphillips
lgtm
6 years, 7 months ago (2014-05-06 13:25:06 UTC) #3
f(malita)
lgtm
6 years, 7 months ago (2014-05-06 13:32:53 UTC) #4
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-06 13:35:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/269163004/1
6 years, 7 months ago (2014-05-06 13:35:18 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 13:43:19 UTC) #7
Message was sent while issue was closed. 
Change committed as 14588

Powered by Google App Engine
This is Rietveld 408576698