Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart

Issue 2691613002: Improve compile-time error handling. (Closed)
Patch Set: Update status and expectations for rasta tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart b/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
index 4e544ad79db8421b182d754b550255cf8676a7b3..31d96d513cefebdfca849b85673fdeca2b278cf2 100644
--- a/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
@@ -58,7 +58,7 @@ class DillLibraryBuilder extends LibraryBuilder<KernelTypeBuilder, Library> {
void addClass(Class cls) {
DillClassBuilder classBulder = new DillClassBuilder(cls, this);
- addBuilder(cls.name, classBulder);
+ addBuilder(cls.name, classBulder, cls.fileOffset);
cls.procedures.forEach(classBulder.addMember);
cls.constructors.forEach(classBulder.addMember);
for (Field field in cls.fields) {
@@ -91,11 +91,11 @@ class DillLibraryBuilder extends LibraryBuilder<KernelTypeBuilder, Library> {
// [compile_platform.dart](../compile_platform.dart).
print("$uri: _exports# not implemented yet.");
} else {
- addBuilder(name, new DillMemberBuilder(member, this));
+ addBuilder(name, new DillMemberBuilder(member, this), member.fileOffset);
}
}
- Builder addBuilder(String name, Builder builder) {
+ Builder addBuilder(String name, Builder builder, int charOffset) {
if (name == null || name.isEmpty) return null;
members[name] = builder;
if (!name.startsWith("_")) {

Powered by Google App Engine
This is Rietveld 408576698