Issue 26916002: Remove SkLumaXfermode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26916002: Remove SkLumaXfermode. (Closed)

Created:
7 years, 2 months ago by f(malita)

Modified:
7 years, 2 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove SkLumaXfermode. Possibly the shortest-lived Skia feature, SkLumaXfermode is now replaced by a color filter implementation (SkLumaColorFilter). All known existing clients (Blink) have been converted. R=reed@google.com Committed: http://code.google.com/p/skia/source/detail?r=11750

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -501 lines)			Patch
M	bench/XfermodeBench.cpp	View	2 chunks	+0 lines, -5 lines	0 comments	Download
D	gm/lumamode.cpp	View	1 chunk	+0 lines, -149 lines	0 comments	Download
M	gyp/effects.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/public_headers.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	include/effects/SkLumaXfermode.h	View	1 chunk	+0 lines, -61 lines	0 comments	Download
D	src/effects/SkLumaXfermode.cpp	View	1 chunk	+0 lines, -278 lines	0 comments	Download
M	src/ports/SkGlobalInitialization_chromium.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/ports/SkGlobalInitialization_default.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/26916002/1

7 years, 2 months ago (2013-10-14 13:11:01 UTC) #3

Message was sent while issue was closed.

Change committed as 11750

Expand Messages | Collapse Messages