Chromium Code Reviews| Index: ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.mm |
| diff --git a/ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.mm b/ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.mm |
| index 85969aab0b4bf71d9508a159b7f6ea5dfe2d1d5f..df655f001ba7b9fbe6badae9e04fc9272ef6cf00 100644 |
| --- a/ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.mm |
| +++ b/ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.mm |
| @@ -17,17 +17,11 @@ |
| @synthesize ID = _ID; |
|
marq (ping after 24h)
2017/02/16 13:14:36
Usually I like shorter names, but 'ID' (and especi
gambard
2017/02/16 13:45:53
Done.
|
| @synthesize title = _title; |
| -- (instancetype)initWithID:(ContentSuggestionsSectionID)ID |
| - emptyCell:(CollectionViewItem*)emptyCell |
| - layout:(ContentSuggestionsSectionLayout)layout |
| - title:(NSString*)title { |
| +- (instancetype)initWithID:(ContentSuggestionsSectionID)ID { |
| self = [super init]; |
| if (self) { |
| - DCHECK(ID < ContentSuggestionsSectionCount); |
| + DCHECK(ID < ContentSuggestionsSectionUnknown); |
| _ID = ID; |
| - _layout = layout; |
|
stkhapugin
2017/02/16 10:53:27
I really find this change weird. You start with gr
gambard
2017/02/16 13:45:53
Can we have your opinion on this marq@?
marq (ping after 24h)
2017/02/17 13:54:13
I'm fine with the change.
|
| - _emptyCell = emptyCell; |
| - _title = [title copy]; |
| } |
| return self; |
| } |