Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | 1 // Copyright 2017 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #import "ios/chrome/browser/ui/content_suggestions/content_suggestions_section_i nformation.h" | 5 #import "ios/chrome/browser/ui/content_suggestions/content_suggestions_section_i nformation.h" |
| 6 | 6 |
| 7 #include "base/logging.h" | 7 #include "base/logging.h" |
| 8 | 8 |
| 9 #if !defined(__has_feature) || !__has_feature(objc_arc) | 9 #if !defined(__has_feature) || !__has_feature(objc_arc) |
| 10 #error "This file requires ARC support." | 10 #error "This file requires ARC support." |
| 11 #endif | 11 #endif |
| 12 | 12 |
| 13 @implementation ContentSuggestionsSectionInformation | 13 @implementation ContentSuggestionsSectionInformation |
| 14 | 14 |
| 15 @synthesize emptyCell = _emptyCell; | 15 @synthesize emptyCell = _emptyCell; |
| 16 @synthesize layout = _layout; | 16 @synthesize layout = _layout; |
| 17 @synthesize ID = _ID; | 17 @synthesize ID = _ID; |
|
marq (ping after 24h)
2017/02/16 13:14:36
Usually I like shorter names, but 'ID' (and especi
gambard
2017/02/16 13:45:53
Done.
| |
| 18 @synthesize title = _title; | 18 @synthesize title = _title; |
| 19 | 19 |
| 20 - (instancetype)initWithID:(ContentSuggestionsSectionID)ID | 20 - (instancetype)initWithID:(ContentSuggestionsSectionID)ID { |
| 21 emptyCell:(CollectionViewItem*)emptyCell | |
| 22 layout:(ContentSuggestionsSectionLayout)layout | |
| 23 title:(NSString*)title { | |
| 24 self = [super init]; | 21 self = [super init]; |
| 25 if (self) { | 22 if (self) { |
| 26 DCHECK(ID < ContentSuggestionsSectionCount); | 23 DCHECK(ID < ContentSuggestionsSectionUnknown); |
| 27 _ID = ID; | 24 _ID = ID; |
| 28 _layout = layout; | |
|
stkhapugin
2017/02/16 10:53:27
I really find this change weird. You start with gr
gambard
2017/02/16 13:45:53
Can we have your opinion on this marq@?
marq (ping after 24h)
2017/02/17 13:54:13
I'm fine with the change.
| |
| 29 _emptyCell = emptyCell; | |
| 30 _title = [title copy]; | |
| 31 } | 25 } |
| 32 return self; | 26 return self; |
| 33 } | 27 } |
| 34 | 28 |
| 35 @end | 29 @end |
| OLD | NEW |