Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2691573002: [ObjC ARC] Converts ios/chrome/browser/ui/static_content:unit_tests to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), jam, noyau+watch_chromium.org, marq+watch_chromium.org, darin-cc_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/static_content:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2691573002 Cr-Commit-Position: refs/heads/master@{#449980} Committed: https://chromium.googlesource.com/chromium/src/+/1c88bac5c868c7345259568ee80dd684ce8ffa25

Patch Set 1 #

Total comments: 2

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -71 lines) Patch
M ios/chrome/browser/ui/static_content/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/static_content/static_html_native_content_unittest.mm View 4 chunks +16 lines, -15 lines 0 comments Download
M ios/chrome/browser/ui/static_content/static_html_view_controller_unittest.mm View 1 6 chunks +47 lines, -56 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
lody
You can haz more arc conversion CLs! Yay!
3 years, 10 months ago (2017-02-13 10:51:24 UTC) #6
sdefresne
lgtm https://codereview.chromium.org/2691573002/diff/1/ios/chrome/browser/ui/static_content/static_html_view_controller_unittest.mm File ios/chrome/browser/ui/static_content/static_html_view_controller_unittest.mm (right): https://codereview.chromium.org/2691573002/diff/1/ios/chrome/browser/ui/static_content/static_html_view_controller_unittest.mm#newcode117 ios/chrome/browser/ui/static_content/static_html_view_controller_unittest.mm:117: id loader; nit: no need for separate line ...
3 years, 10 months ago (2017-02-13 14:19:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691573002/20001
3 years, 10 months ago (2017-02-13 15:58:42 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 16:53:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1c88bac5c868c7345259568ee80d...

Powered by Google App Engine
This is Rietveld 408576698