Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: pkg/front_end/lib/src/fasta/builder/metadata_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/builder/metadata_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/metadata_builder.dart b/pkg/front_end/lib/src/fasta/builder/metadata_builder.dart
index 594c6f359611d65dcc951a2dfade0e79b685816b..a060d2edbe240a5347656a1f5553f08d608141d4 100644
--- a/pkg/front_end/lib/src/fasta/builder/metadata_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/metadata_builder.dart
@@ -12,15 +12,20 @@ import 'constructor_reference_builder.dart' show
ConstructorReferenceBuilder;
abstract class MetadataBuilder<T extends TypeBuilder> extends Builder {
- MetadataBuilder();
+ MetadataBuilder(Builder parent, int charOffset)
+ : super(parent, -1, parent.fileUri);
factory MetadataBuilder.fromConstructor(
- ConstructorReferenceBuilder constructorReference, List arguments) {
- return new ConstructorMetadataBuilder(constructorReference, arguments);
+ ConstructorReferenceBuilder constructorReference, List arguments,
+ Builder parent, int charOffset) {
+ return new ConstructorMetadataBuilder(constructorReference, arguments,
+ parent, charOffset);
}
- factory MetadataBuilder.fromExpression(String expression, String postfix) {
- return new ExpressionMetadataBuilder(expression, postfix);
+ factory MetadataBuilder.fromExpression(String expression, String postfix,
+ Builder parent, int charOffset) {
+ return new ExpressionMetadataBuilder(
+ expression, postfix, parent, charOffset);
}
}
@@ -30,7 +35,9 @@ class ConstructorMetadataBuilder<T extends TypeBuilder>
final List arguments;
- ConstructorMetadataBuilder(this.constructorReference, this.arguments);
+ ConstructorMetadataBuilder(this.constructorReference, this.arguments,
+ Builder parent, int charOffset)
+ : super(parent, charOffset);
}
/// Expression metadata (without arguments).
@@ -44,5 +51,7 @@ class ExpressionMetadataBuilder<T extends TypeBuilder>
final String identifier;
- ExpressionMetadataBuilder(this.qualified, this.identifier);
+ ExpressionMetadataBuilder(this.qualified, this.identifier, Builder parent,
+ int charOffset)
+ : super(parent, charOffset);
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/member_builder.dart ('k') | pkg/front_end/lib/src/fasta/builder/mixed_accessor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698