pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart - Issue 2691523002: Ensure locations are always provided, but don't store them yet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)

Patch Set: Address comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/class_builder.dart ('k') | pkg/front_end/lib/src/fasta/builder/dynamic_type_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart b/pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart

index 21f5e3ba3ff2031bad80e4546feaa6dcc7d23a96..019fb4c0fdd9625b03bb46a5b5397f8a4685770a 100644

--- a/pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart

+++ b/pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart

@@ -23,7 +23,9 @@ class ConstructorReferenceBuilder extends Builder {

Builder target;

- ConstructorReferenceBuilder(this.name, this.typeArguments, this.suffix);

+ ConstructorReferenceBuilder(this.name, this.typeArguments, this.suffix,

+ Builder parent, int charOffset)

+ : super(parent, charOffset, parent.fileUri);

String get fullNameForErrors => "$name${suffix == null ? '' : '.$suffix'}";

@@ -31,11 +33,11 @@ class ConstructorReferenceBuilder extends Builder {

int index = name.indexOf(".");

Builder builder;

if (index == -1) {

- builder = scope.lookup(name);

+ builder = scope.lookup(name, charOffset, fileUri);

} else {

String prefix = name.substring(0, index);

String middle = name.substring(index + 1);

- builder = scope.lookup(prefix);

+ builder = scope.lookup(prefix, charOffset, fileUri);

if (builder is PrefixBuilder) {

PrefixBuilder prefix = builder;

builder = prefix.exports[middle];