Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Missing file. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart b/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
index 3041dfd70e0cd77d9421e9039f31b0385d3f0bb0..4e544ad79db8421b182d754b550255cf8676a7b3 100644
--- a/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
@@ -49,7 +49,8 @@ class DillLibraryBuilder extends LibraryBuilder<KernelTypeBuilder, Library> {
Library library;
- DillLibraryBuilder(this.uri, this.loader);
+ DillLibraryBuilder(Uri uri, this.loader)
+ : uri = uri, super(uri);
Johnni Winther 2017/02/13 08:42:03 Isn't initializing formal also parameters now by d
ahe 2017/02/13 10:44:23 I don't know. I'd like to be able to continue per
get scope => internalError("Scope not supported");
@@ -112,7 +113,7 @@ class DillLibraryBuilder extends LibraryBuilder<KernelTypeBuilder, Library> {
}
KernelInvalidTypeBuilder buildAmbiguousBuilder(
- String name, Builder builder, Builder other) {
- return new KernelInvalidTypeBuilder(name, this);
+ String name, Builder builder, Builder other, int charOffset) {
+ return new KernelInvalidTypeBuilder(name, charOffset, fileUri);
}
}

Powered by Google App Engine
This is Rietveld 408576698