Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issue 2691503002: Adjust the width of the ReadingList empty text (Closed)

Created:
3 years, 10 months ago by gambard
Modified:
3 years, 10 months ago
Reviewers:
Olivier
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust the width of the ReadingList empty text The text now has a max width of 270pt. BUG=690451 Review-Url: https://codereview.chromium.org/2691503002 Cr-Commit-Position: refs/heads/master@{#449612} Committed: https://chromium.googlesource.com/chromium/src/+/8dabb468fa293d1f5c359549305ef1867c6805e9

Patch Set 1 #

Patch Set 2 : Remove carret alpha #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -26 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm View 1 10 chunks +32 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gambard
PTAL.
3 years, 10 months ago (2017-02-10 11:43:50 UTC) #2
Olivier
lgtm
3 years, 10 months ago (2017-02-10 14:13:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691503002/20001
3 years, 10 months ago (2017-02-10 14:13:54 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 14:25:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8dabb468fa293d1f5c359549305e...

Powered by Google App Engine
This is Rietveld 408576698