Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Issue 2691493003: Add keep_cronet_api.xml to keep @string/CronetProviderClassName (Closed)

Created:
3 years, 10 months ago by kapishnikov
Modified:
3 years, 10 months ago
Reviewers:
pauljensen, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add keep_cronet_api.xml to keep @string/CronetProviderClassName BUG=690495 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2691493003 Cr-Commit-Position: refs/heads/master@{#449737} Committed: https://chromium.googlesource.com/chromium/src/+/1d72039b3d964ca71077ffb8208c62215a4735a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M components/cronet/android/BUILD.gn View 2 chunks +10 lines, -0 lines 0 comments Download
A components/cronet/android/api/res/raw/keep_cronet_api.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kapishnikov
PTAL
3 years, 10 months ago (2017-02-10 16:57:54 UTC) #3
pauljensen
lgtm
3 years, 10 months ago (2017-02-10 18:05:45 UTC) #4
mef
lgtm
3 years, 10 months ago (2017-02-10 19:44:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691493003/1
3 years, 10 months ago (2017-02-10 19:46:49 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 21:23:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d72039b3d964ca71077ffb8208c...

Powered by Google App Engine
This is Rietveld 408576698