Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2691493002: arc: Add splash screen for ARC++ Kiosk startup (Closed)

Created:
3 years, 10 months ago by Sergey Poromov
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

arc: Add splash screen for ARC++ Kiosk startup Implemented similar to App Launch Splash Screen that is used for Chrome Kiosk. Splash screen is shown immediately after launching ARC++ Kiosk session and destructed when app window is launched. This leads to no UI exposed, except to sign in screen, splash screen and finally app window. User can escape launching of the app by pressing Ctrl+Alt+S during the splash screen. Also fixes bug of restarting app few seconds after launch. BUG=682778, 682780, 681111, 677310 TEST=Manual, Start ARC++ Kiosk sessions. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2649103006 Cr-Commit-Position: refs/heads/master@{#448075} (cherry picked from commit af6c8bbf83b31deb1a772193dff2ff2871f4fbd7) Review-Url: https://codereview.chromium.org/2691493002 . Cr-Commit-Position: refs/branch-heads/2987@{#432} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9a3e555a3952276620ae2274a6707ff49357ed0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+698 lines, -17 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_launcher.h View 2 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_launcher.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.h View 3 chunks +22 lines, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc View 5 chunks +17 lines, -2 lines 0 comments Download
A chrome/browser/chromeos/login/arc_kiosk_controller.h View 1 chunk +84 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/arc_kiosk_controller.cc View 1 chunk +132 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_screen.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_screen.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/chromeos/login/screens/arc_kiosk_splash_screen_actor.h View 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 4 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/mock_login_display_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_non_lock_shared.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_non_lock_shared.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_screens.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screens.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/screen_arc_kiosk_splash.css View 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/screen_arc_kiosk_splash.html View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/screen_arc_kiosk_splash.js View 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.h View 1 chunk +54 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.cc View 1 chunk +120 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 5 chunks +17 lines, -7 lines 0 comments Download
M ui/login/display_manager.js View 3 chunks +4 lines, -0 lines 0 comments Download
M ui/login/screen_container.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Sergey Poromov
3 years, 10 months ago (2017-02-10 11:03:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a3e555a3952276620ae2274a6707ff49357ed0f.

Powered by Google App Engine
This is Rietveld 408576698