Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2691483005: Mojo Bindings: Put typemap files in the build dependency tree (Closed)

Created:
3 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 10 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo Bindings: Put typemap files in the build dependency tree This ensures that any typemap configuration files used to configure an internal type-mappings-generator target are included in that target's set of inputs. Otherwise this dependency only comes in the form of read_file() calls made outside of any target scope, and GN fails to deduce the effect this has on mojom targets. BUG=691081 Review-Url: https://codereview.chromium.org/2691483005 Cr-Commit-Position: refs/heads/master@{#450002} Committed: https://chromium.googlesource.com/chromium/src/+/ba3fc0dad59f9be26ce99f2aae4626cfc0330d2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -22 lines) Patch
M mojo/public/tools/bindings/blink_bindings_configuration.gni View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 2 chunks +8 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 4 chunks +42 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Ken Rockot(use gerrit already)
3 years, 10 months ago (2017-02-10 23:39:48 UTC) #4
jam
lgtm, thanks!
3 years, 10 months ago (2017-02-13 16:39:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691483005/1
3 years, 10 months ago (2017-02-13 16:48:39 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 17:59:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba3fc0dad59f9be26ce99f2aae46...

Powered by Google App Engine
This is Rietveld 408576698