Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2691443002: Have codePointAt DCHECKS apply to 8bit strings too (Closed)

Created:
3 years, 10 months ago by eae
Modified:
3 years, 10 months ago
Reviewers:
szager1
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have codePointAt DCHECKS apply to 8bit strings too BUG=690218 R=szager@chromium.org Review-Url: https://codereview.chromium.org/2691443002 Cr-Commit-Position: refs/heads/master@{#449540} Committed: https://chromium.googlesource.com/chromium/src/+/357719bae98584d89410828312d37fe6cdc15b03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/text/TextRun.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
eae
3 years, 10 months ago (2017-02-09 23:30:20 UTC) #1
szager1
lgtm
3 years, 10 months ago (2017-02-09 23:42:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691443002/1
3 years, 10 months ago (2017-02-10 00:25:43 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 02:59:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/357719bae98584d89410828312d3...

Powered by Google App Engine
This is Rietveld 408576698