Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2691433008: AnalysisDriver.getUnitElement() should return a structure with a key. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

AnalysisDriver.getUnitElement() should return a structure with a key. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/65559748eb44f5acf882af3f5e43fbf391e1539d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -46 lines) Patch
M pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart View 18 chunks +32 lines, -19 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 5 chunks +52 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/search.dart View 4 chunks +14 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-11 23:31:19 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-12 16:23:11 UTC) #2
scheglov
3 years, 10 months ago (2017-02-12 22:58:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
65559748eb44f5acf882af3f5e43fbf391e1539d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698