Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: pkg/analyzer/lib/src/dart/analysis/search.dart

Issue 2691433008: AnalysisDriver.getUnitElement() should return a structure with a key. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/dart/analysis/search.dart
diff --git a/pkg/analyzer/lib/src/dart/analysis/search.dart b/pkg/analyzer/lib/src/dart/analysis/search.dart
index 8b81db95a132a2a595310aed1c654cff51b1b8d4..6bb75be6fc6449924891d740760ccd1920aef659 100644
--- a/pkg/analyzer/lib/src/dart/analysis/search.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/search.dart
@@ -47,9 +47,9 @@ class Search {
List<String> files = await _driver.getFilesDefiningClassMemberName(name);
for (String file in files) {
- CompilationUnitElement unitElement = await _driver.getUnitElement(file);
- if (unitElement != null) {
- for (ClassElement clazz in unitElement.types) {
+ UnitElementResult unitResult = await _driver.getUnitElement(file);
+ if (unitResult != null) {
+ for (ClassElement clazz in unitResult.element.types) {
clazz.accessors.forEach(addElement);
clazz.fields.forEach(addElement);
clazz.methods.forEach(addElement);
@@ -132,9 +132,9 @@ class Search {
}
for (FileState file in _driver.fsState.knownFiles) {
- CompilationUnitElement unitElement =
- await _driver.getUnitElement(file.path);
- if (unitElement != null) {
+ UnitElementResult unitResult = await _driver.getUnitElement(file.path);
+ if (unitResult != null) {
+ CompilationUnitElement unitElement = unitResult.element;
unitElement.accessors.forEach(addElement);
unitElement.enums.forEach(addElement);
unitElement.functions.forEach(addElement);
@@ -171,7 +171,7 @@ class Search {
IndexRelationKind.IS_READ_WRITTEN_BY: SearchResultKind.READ_WRITE,
IndexRelationKind.IS_INVOKED_BY: SearchResultKind.INVOCATION
},
- () => _driver.getUnitElement(file));
+ () => _getUnitElement(file));
results.addAll(fileResults);
}
}
@@ -227,13 +227,18 @@ class Search {
_IndexRequest request = new _IndexRequest(index);
int elementId = request.findElementId(element);
if (elementId != -1) {
- List<SearchResult> fileResults = await request.getRelations(elementId,
- relationToResultKind, () => _driver.getUnitElement(file));
+ List<SearchResult> fileResults = await request.getRelations(
+ elementId, relationToResultKind, () => _getUnitElement(file));
results.addAll(fileResults);
}
}
}
+ Future<CompilationUnitElement> _getUnitElement(String file) async {
+ UnitElementResult result = await _driver.getUnitElement(file);
+ return result?.element;
+ }
+
Future<List<SearchResult>> _searchReferences(Element element) async {
List<SearchResult> results = <SearchResult>[];
await _addResults(results, element,
« no previous file with comments | « pkg/analyzer/lib/src/dart/analysis/driver.dart ('k') | pkg/analyzer/test/src/dart/analysis/driver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698