Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2691433002: Make Blink support multiline text insertion (Closed)

Created:
3 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Make Blink support multiline text insertion When inserting multiline text, Blink will insert the text before '\n' and the text after the '\n' separately, e.g., for "hello\nworld", Blink will insert "hello", then a paragraph separator, then "world". However, after inserting "hello", the text is updated to "hello" incorrectly, so the remaining "world" will not be inserted. This CL moves the text-updating logic to upper level to make it right. Besides, this CL adjusts the selection after each insertion for incremental insertion. BUG=683885 Review-Url: https://codereview.chromium.org/2680733002 Cr-Commit-Position: refs/heads/master@{#448920} (cherry picked from commit 286c2ce88f848617aff81090e9cc41afdf5de7e5) Review-Url: https://codereview.chromium.org/2691433002 . Cr-Commit-Position: refs/branch-heads/2987@{#422} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/51c86d6f3e40a86b4fb2d8a08442b808ccfa8a1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -52 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 11 chunks +48 lines, -48 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
3 years, 10 months ago (2017-02-09 23:20:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
51c86d6f3e40a86b4fb2d8a08442b808ccfa8a1e.

Powered by Google App Engine
This is Rietveld 408576698