Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2691423003: [tests] Add js-perf-test for %TypedArray%.prototype.sort (Closed)

Created:
3 years, 10 months ago by Choongwoo Han
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tests] Add js-perf-test for %TypedArray%.prototype.sort - Add benchmark for sorting of Float64Array - Rename existing typedarray.js to copywithin.js BUG=v8:5953 R=bmeurer@chromium.org, caitp@chromium.org, petermarshall@chromium.org Review-Url: https://codereview.chromium.org/2691423003 Cr-Commit-Position: refs/heads/master@{#43217} Committed: https://chromium.googlesource.com/v8/v8/+/693b741f6d461cec576503255c2069c642880f94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -32 lines) Patch
M test/js-perf-test/JSTests.json View 2 chunks +6 lines, -1 line 0 comments Download
A + test/js-perf-test/TypedArrays/copywithin.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A test/js-perf-test/TypedArrays/sort.js View 1 chunk +33 lines, -0 lines 0 comments Download
D test/js-perf-test/TypedArrays/typedarrays.js View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Choongwoo Han
3 years, 10 months ago (2017-02-15 08:12:20 UTC) #1
Benedikt Meurer
Thank you! LGTM.
3 years, 10 months ago (2017-02-15 08:37:07 UTC) #2
petermarshall
LGTM with nit: Please fix typo in description "coptywithin". Thanks
3 years, 10 months ago (2017-02-15 08:57:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691423003/1
3 years, 10 months ago (2017-02-15 14:47:06 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 14:48:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/693b741f6d461cec576503255c2069c6428...

Powered by Google App Engine
This is Rietveld 408576698