Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: ui/views/layout/grid_layout.cc

Issue 2691393002: Fix auto raw pointer deduction on linux (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/examples/button_sticker_sheet.cc ('k') | ui/views/test/ui_controls_factory_desktop_aurax11.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/layout/grid_layout.cc
diff --git a/ui/views/layout/grid_layout.cc b/ui/views/layout/grid_layout.cc
index eb4dd9d18899365686159616557ca859b9cb5352..8c7dcfb4516b50b4ae92b21557f69a3ea5cfd699 100644
--- a/ui/views/layout/grid_layout.cc
+++ b/ui/views/layout/grid_layout.cc
@@ -236,11 +236,11 @@ void Column::UnifySameSizedColumnSizes() {
// Accumulate the size first.
int size = 0;
- for (auto column : same_size_columns_)
+ for (auto* column : same_size_columns_)
size = std::max(size, column->Size());
// Then apply it.
- for (auto column : same_size_columns_)
+ for (auto* column : same_size_columns_)
column->SetSize(size);
}
@@ -496,7 +496,7 @@ void ColumnSet::AccumulateMasterColumns() {
}
void ColumnSet::UnifySameSizedColumnSizes() {
- for (auto column : master_columns_)
+ for (auto* column : master_columns_)
column->UnifySameSizedColumnSizes();
}
@@ -583,7 +583,7 @@ void ColumnSet::ResetColumnXCoordinates() {
void ColumnSet::CalculateSize() {
gfx::Size pref;
// Reset the preferred and remaining sizes.
- for (const auto& view_state : view_states_) {
+ for (auto* view_state : view_states_) {
if (!view_state->pref_width_fixed || !view_state->pref_height_fixed) {
pref = view_state->view->GetPreferredSize();
if (!view_state->pref_width_fixed)
« no previous file with comments | « ui/views/examples/button_sticker_sheet.cc ('k') | ui/views/test/ui_controls_factory_desktop_aurax11.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698