Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: ui/message_center/views/message_list_view.cc

Issue 2691393002: Fix auto raw pointer deduction on linux (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/notification_list.cc ('k') | ui/message_center/views/message_list_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/views/message_list_view.cc
diff --git a/ui/message_center/views/message_list_view.cc b/ui/message_center/views/message_list_view.cc
index 51158fdecec0d20e58fb3f1cb827c7b27ab6136b..92d5d7fd7edfaf7b8c0bc48958df7fdd1bade6b3 100644
--- a/ui/message_center/views/message_list_view.cc
+++ b/ui/message_center/views/message_list_view.cc
@@ -188,7 +188,7 @@ void MessageListView::ResetRepositionSession() {
has_deferred_task_ = false;
// cancel cause OnBoundsAnimatorDone which deletes |deleted_when_done_|.
animator_.Cancel();
- for (auto view : deleting_views_)
+ for (auto* view : deleting_views_)
delete view;
deleting_views_.clear();
adding_views_.clear();
@@ -230,7 +230,7 @@ void MessageListView::RemoveObserver(MessageListView::Observer* observer) {
void MessageListView::OnBoundsAnimatorProgressed(
views::BoundsAnimator* animator) {
DCHECK_EQ(&animator_, animator);
- for (auto view : deleted_when_done_) {
+ for (auto* view : deleted_when_done_) {
const gfx::SlideAnimation* animation = animator->GetAnimationForView(view);
if (animation)
view->layer()->SetOpacity(animation->CurrentValueBetween(1.0, 0.0));
@@ -238,7 +238,7 @@ void MessageListView::OnBoundsAnimatorProgressed(
}
void MessageListView::OnBoundsAnimatorDone(views::BoundsAnimator* animator) {
- for (auto view : deleted_when_done_)
+ for (auto* view : deleted_when_done_)
delete view;
deleted_when_done_.clear();
« no previous file with comments | « ui/message_center/notification_list.cc ('k') | ui/message_center/views/message_list_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698