Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: remoting/host/host_extension_session_manager.cc

Issue 2691393002: Fix auto raw pointer deduction on linux (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/tools/quic/end_to_end_test.cc ('k') | remoting/protocol/jingle_session.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/host/host_extension_session_manager.h" 5 #include "remoting/host/host_extension_session_manager.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "remoting/base/capabilities.h" 8 #include "remoting/base/capabilities.h"
9 #include "remoting/host/client_session_details.h" 9 #include "remoting/host/client_session_details.h"
10 #include "remoting/host/host_extension.h" 10 #include "remoting/host/host_extension.h"
11 #include "remoting/host/host_extension_session.h" 11 #include "remoting/host/host_extension_session.h"
12 12
13 namespace remoting { 13 namespace remoting {
14 14
15 HostExtensionSessionManager::HostExtensionSessionManager( 15 HostExtensionSessionManager::HostExtensionSessionManager(
16 const HostExtensions& extensions, 16 const HostExtensions& extensions,
17 ClientSessionDetails* client_session_details) 17 ClientSessionDetails* client_session_details)
18 : client_session_details_(client_session_details), 18 : client_session_details_(client_session_details),
19 client_stub_(nullptr), 19 client_stub_(nullptr),
20 extensions_(extensions) {} 20 extensions_(extensions) {}
21 21
22 HostExtensionSessionManager::~HostExtensionSessionManager() {} 22 HostExtensionSessionManager::~HostExtensionSessionManager() {}
23 23
24 std::string HostExtensionSessionManager::GetCapabilities() const { 24 std::string HostExtensionSessionManager::GetCapabilities() const {
25 std::string capabilities; 25 std::string capabilities;
26 for (const auto& extension : extensions_) { 26 for (auto* extension : extensions_) {
27 const std::string& capability = extension->capability(); 27 const std::string& capability = extension->capability();
28 if (capability.empty()) { 28 if (capability.empty()) {
29 continue; 29 continue;
30 } 30 }
31 if (!capabilities.empty()) { 31 if (!capabilities.empty()) {
32 capabilities.append(" "); 32 capabilities.append(" ");
33 } 33 }
34 capabilities.append(capability); 34 capabilities.append(capability);
35 } 35 }
36 return capabilities; 36 return capabilities;
37 } 37 }
38 38
39 void HostExtensionSessionManager::OnNegotiatedCapabilities( 39 void HostExtensionSessionManager::OnNegotiatedCapabilities(
40 protocol::ClientStub* client_stub, 40 protocol::ClientStub* client_stub,
41 const std::string& capabilities) { 41 const std::string& capabilities) {
42 DCHECK(client_stub); 42 DCHECK(client_stub);
43 DCHECK(!client_stub_); 43 DCHECK(!client_stub_);
44 44
45 client_stub_ = client_stub; 45 client_stub_ = client_stub;
46 46
47 for (const auto& extension : extensions_) { 47 for (auto* extension : extensions_) {
48 // If the extension requires a capability that was not negotiated then do 48 // If the extension requires a capability that was not negotiated then do
49 // not instantiate it. 49 // not instantiate it.
50 if (!extension->capability().empty() && 50 if (!extension->capability().empty() &&
51 !HasCapability(capabilities, extension->capability())) { 51 !HasCapability(capabilities, extension->capability())) {
52 continue; 52 continue;
53 } 53 }
54 54
55 std::unique_ptr<HostExtensionSession> extension_session = 55 std::unique_ptr<HostExtensionSession> extension_session =
56 extension->CreateExtensionSession(client_session_details_, 56 extension->CreateExtensionSession(client_session_details_,
57 client_stub_); 57 client_stub_);
58 DCHECK(extension_session); 58 DCHECK(extension_session);
59 59
60 extension_sessions_.push_back(std::move(extension_session)); 60 extension_sessions_.push_back(std::move(extension_session));
61 } 61 }
62 } 62 }
63 63
64 bool HostExtensionSessionManager::OnExtensionMessage( 64 bool HostExtensionSessionManager::OnExtensionMessage(
65 const protocol::ExtensionMessage& message) { 65 const protocol::ExtensionMessage& message) {
66 for (const auto& session : extension_sessions_) { 66 for (const auto& session : extension_sessions_) {
67 if (session->OnExtensionMessage(client_session_details_, client_stub_, 67 if (session->OnExtensionMessage(client_session_details_, client_stub_,
68 message)) { 68 message)) {
69 return true; 69 return true;
70 } 70 }
71 } 71 }
72 return false; 72 return false;
73 } 73 }
74 74
75 } // namespace remoting 75 } // namespace remoting
OLDNEW
« no previous file with comments | « net/tools/quic/end_to_end_test.cc ('k') | remoting/protocol/jingle_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698