Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: content/browser/media/session/audio_focus_manager.cc

Issue 2691393002: Fix auto raw pointer deduction on linux (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/media/session/audio_focus_manager.h" 5 #include "content/browser/media/session/audio_focus_manager.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "content/browser/media/session/media_session_impl.h" 8 #include "content/browser/media/session/media_session_impl.h"
9 #include "content/public/browser/web_contents.h" 9 #include "content/public/browser/web_contents.h"
10 10
(...skipping 16 matching lines...) Expand all
27 } 27 }
28 28
29 MaybeRemoveFocusEntry(media_session); 29 MaybeRemoveFocusEntry(media_session);
30 30
31 // TODO(zqzhang): It seems like MediaSessionImpl is exposed to 31 // TODO(zqzhang): It seems like MediaSessionImpl is exposed to
32 // AudioFocusManager 32 // AudioFocusManager
33 // too much. Maybe it's better to do some abstraction and refactoring to clean 33 // too much. Maybe it's better to do some abstraction and refactoring to clean
34 // up the relation between AudioFocusManager and MediaSessionImpl. 34 // up the relation between AudioFocusManager and MediaSessionImpl.
35 // See https://crbug.com/651069 35 // See https://crbug.com/651069
36 if (type == AudioFocusType::GainTransientMayDuck) { 36 if (type == AudioFocusType::GainTransientMayDuck) {
37 for (const auto old_session : audio_focus_stack_) { 37 for (auto* old_session : audio_focus_stack_) {
38 old_session->StartDucking(); 38 old_session->StartDucking();
39 } 39 }
40 } else { 40 } else {
41 for (const auto old_session : audio_focus_stack_) { 41 for (auto* old_session : audio_focus_stack_) {
42 if (old_session->IsActive()) { 42 if (old_session->IsActive()) {
43 if (old_session->HasPepper()) 43 if (old_session->HasPepper())
44 old_session->StartDucking(); 44 old_session->StartDucking();
45 else 45 else
46 old_session->Suspend(MediaSessionImpl::SuspendType::SYSTEM); 46 old_session->Suspend(MediaSessionImpl::SuspendType::SYSTEM);
47 } 47 }
48 } 48 }
49 } 49 }
50 50
51 audio_focus_stack_.push_back(media_session); 51 audio_focus_stack_.push_back(media_session);
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 87
88 AudioFocusManager::AudioFocusManager() = default; 88 AudioFocusManager::AudioFocusManager() = default;
89 89
90 AudioFocusManager::~AudioFocusManager() = default; 90 AudioFocusManager::~AudioFocusManager() = default;
91 91
92 void AudioFocusManager::MaybeRemoveFocusEntry(MediaSessionImpl* media_session) { 92 void AudioFocusManager::MaybeRemoveFocusEntry(MediaSessionImpl* media_session) {
93 audio_focus_stack_.remove(media_session); 93 audio_focus_stack_.remove(media_session);
94 } 94 }
95 95
96 } // namespace content 96 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/resource_loader.cc ('k') | content/browser/memory/memory_coordinator_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698