Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2691363004: chromeos: Makes ~QuickLaunch delete widgets (Closed)

Created:
3 years, 10 months ago by sky
Modified:
3 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Makes ~QuickLaunch delete widgets BUG=692324 TEST=none R=erg@chromium.org Review-Url: https://codereview.chromium.org/2691363004 Cr-Commit-Position: refs/heads/master@{#450815} Committed: https://chromium.googlesource.com/chromium/src/+/32e074e42207bf161510aba4c4b5539d0818d2f1

Patch Set 1 #

Total comments: 2

Patch Set 2 : newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M mash/quick_launch/quick_launch.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
sky
3 years, 10 months ago (2017-02-15 20:07:25 UTC) #1
Elliot Glaysher
lgtm https://codereview.chromium.org/2691363004/diff/1/mash/quick_launch/quick_launch.cc File mash/quick_launch/quick_launch.cc (right): https://codereview.chromium.org/2691363004/diff/1/mash/quick_launch/quick_launch.cc#newcode156 mash/quick_launch/quick_launch.cc:156: } nit: newline between ctor and dtor?
3 years, 10 months ago (2017-02-15 20:08:31 UTC) #2
sky
https://codereview.chromium.org/2691363004/diff/1/mash/quick_launch/quick_launch.cc File mash/quick_launch/quick_launch.cc (right): https://codereview.chromium.org/2691363004/diff/1/mash/quick_launch/quick_launch.cc#newcode156 mash/quick_launch/quick_launch.cc:156: } On 2017/02/15 20:08:30, Elliot Glaysher wrote: > nit: ...
3 years, 10 months ago (2017-02-15 20:10:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691363004/20001
3 years, 10 months ago (2017-02-15 20:11:01 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 21:51:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/32e074e42207bf161510aba4c4b5...

Powered by Google App Engine
This is Rietveld 408576698